+Change some SIS2 axis units to CMIP standards #237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MitchBushuk
previously approved these changes
Jan 7, 2026
Contributor
MitchBushuk
left a comment
MitchBushuk
left a comment
There was a problem hiding this comment.
This appears to be a useful and benign change. It makes SIS2 consistent with CMIP and MOM6 standards, which is a useful improvement.
Modified set_SIS_axes_info to follow the pattern from MOM6 and take the units for the horizontal axes from the grid type. In most cases, this has the effect of changing the units from "degrees_E" and "degrees_N" to "degrees_east" and "degrees_north" to follow CMIP protocols, and to mirror changes that were made to MOM6 in 2017. All solutions are bitwise identical, but there are changes to the metadata in some output files, and some runtime parameters that had been read from both `set_SIS_axes_info()` and `set_grid_metrics()` in MOM6/src/initialization/MOM_grid_initialize.F90 are now only read in the latter routine. As a result of these changes, `set_SIS_axes_info()` no longer takes a `param_file_type` argument and the grid arguments are now `intent(in)`.
Hallberg-NOAA
force-pushed
the
set_axis_units_from_grid
branch
from
55f968f to
5e29c39
Compare
Member
Author
|
This PR has passed pipeline testing at https://gitlab.gfdl.noaa.gov/ogrp/mom6ci/SIS2/-/pipelines/29868. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified
set_SIS_axes_info()to follow the pattern from MOM6 and take the units for the horizontal axes from the grid type. In most cases, this has the effect of changing the units from "degrees_E" and "degrees_N" to "degrees_east" and "degrees_north" to follow CMIP protocols, and to mirror changes that were made to MOM6 in 2017. All solutions are bitwise identical, but there are changes to the metadata in some output files, and some runtime parameters that had been read from bothset_SIS_axes_info()andset_grid_metrics()in MOM6/src/initialization/MOM_grid_initialize.F90 are now only read in the latter routine. As a result of these changes,set_SIS_axes_info()no longer takes aparam_file_typeargument and the grid arguments are nowintent(in).